gtest.a exports symbols, causing link-time warning: direct access in function ... means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

[Kimmo Kinnunen]

gtest.a exports symbols, causing link-time warning: direct access in function ... means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

ld: warning: direct access in function 'testing::internal::SuiteApiResolver<testing::internal::(anonymous namespace)::FailureTest>::GetSetUpCaseOrSuite(char const*, int)' from file '/Users/kkinnunen/Build/Debug/libgtest.a(gtest-all.o)' to global weak symbol 'testing::Test::SetUpTestSuite()' from file '/Users/kkinnunen/Build/Debug/libTestWTF.a(AtomString.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

This is due to gtest.a static library is being compiled with dynamic library settings.
This causes the symbols to be marked as default visibility.
This is being worked around by hiding the symbols explicitly via ld flags
This causes ld warning.

[Kimmo Kinnunen]

Chromium similar setup (at the time of writing):
https://chromium.googlesource.com/chromium/src/+/master/third_party/googletest/BUILD.gn

[Kimmo Kinnunen]

Created attachment 426544 [details]
Patch

[EWS]

Committed r276319 (236800@main): <https://commits.webkit.org/236800@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426544 [details].

[Ling Ho]

rdar://76920626