Bug 224777 - Web Inspector: Grid overlay column line label placement copy/paste error
Summary: Web Inspector: Grid overlay column line label placement copy/paste error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 221972
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-19 12:09 PDT by Patrick Angle
Modified: 2021-04-19 14:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch v1.0 (2.38 KB, patch)
2021-04-19 12:22 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-04-19 12:09:56 PDT
Bug 221972 added logic to place line labels inside the grid when there was not enough space outside of the grid. In that patch, there is a typo for column line label positioning where the line for the label does not extend from the top to the bottom of the column. In practice, this is not noticeable with the current logic, as only the first line will use the line for label placement, and all other columns use only the starting point of the line. None the less, this is currently wrong, and could complicate future fixes that assumed the line was actually a line and not a point in disguise.
Comment 1 Radar WebKit Bug Importer 2021-04-19 12:10:20 PDT
<rdar://problem/76856774>
Comment 2 Patrick Angle 2021-04-19 12:22:52 PDT
Created attachment 426460 [details]
Patch v1.0
Comment 3 Devin Rousso 2021-04-19 13:05:33 PDT
Comment on attachment 426460 [details]
Patch v1.0

rs=me
Comment 4 EWS 2021-04-19 14:18:07 PDT
Committed r276274 (236756@main): <https://commits.webkit.org/236756@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426460 [details].