Bug 224769 - Rename FloatQuad::isEmpty() to boundingBoxIsEmpty() and reimplement isEmpty()
Summary: Rename FloatQuad::isEmpty() to boundingBoxIsEmpty() and reimplement isEmpty()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-19 10:28 PDT by Wenson Hsieh
Modified: 2021-04-23 02:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.39 KB, patch)
2021-04-19 12:34 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For landing (9.45 KB, patch)
2021-04-19 13:08 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-04-19 10:28:16 PDT 
.
Comment 1 Wenson Hsieh 2021-04-19 12:34:20 PDT 
Created attachment 426462 [details]
Patch
Comment 2 Tim Horton 2021-04-19 13:01:44 PDT 
Comment on attachment 426462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review

> Source/WebCore/platform/graphics/FloatQuad.h:-80
> -    // isEmpty tests that the bounding box is empty. This will not identify
> -    // "slanted" empty quads.

Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads".
Comment 3 Wenson Hsieh 2021-04-19 13:03:32 PDT 
Comment on attachment 426462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review

Thanks for the review!

>> Source/WebCore/platform/graphics/FloatQuad.h:-80
>> -    // "slanted" empty quads.
> 
> Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads".

Makes sense — I'll keep the comment, as `// This method will not identify "slanted" empty quads.`
Comment 4 Wenson Hsieh 2021-04-19 13:08:57 PDT 
Created attachment 426466 [details]
For landing
Comment 5 EWS 2021-04-19 15:21:02 PDT 
Committed r276275 (236757@main): <https://commits.webkit.org/236757@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426466 [details].
Comment 6 Ling Ho 2021-04-23 02:59:23 PDT 
rdar://76880824