Bug 224763 – Separated models don't get opacity set on them at all

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Separated models don't get opacity set on them at all

[Sam Weinig]

Created attachment 426428 [details]
Patch

[Sam Weinig]

Created attachment 426464 [details]
Patch

[Sam Weinig]

Created attachment 426480 [details]
Patch

[Sam Weinig]

Created attachment 426564 [details]
Patch

[Sam Weinig]

Now with tests!

[Tim Horton]

Comment on attachment 426564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426564&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3946
> +    if (&layer == m_contentsLayer.get()) {

I love this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3987
> +        if (flags.contains(PlatformLayerTreeAsTextFlags::IncludeOpacity))

It is probably overkill to add a flag for opacity, just only dump it if it's non-1? But this is fine too.

> LayoutTests/model-element/model-element-graphics-layers.html:22
> +        model.remove();

subtle and hilarious. someday we should really debug this.

[Simon Fraser (smfr)]

Comment on attachment 426564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426564&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3987
>> +        if (flags.contains(PlatformLayerTreeAsTextFlags::IncludeOpacity))
> 
> It is probably overkill to add a flag for opacity, just only dump it if it's non-1? But this is fine too.

Agree

[EWS]

Committed r276327 (236807@main): <https://commits.webkit.org/236807@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426564 [details].

[Sam Weinig]

For future historians, the removal of the model was not actually necessary. All we really needed to do was fix the </p> to be </pre>.

[Ling Ho]

rdar://76978806