Bug 224762 – Switch commit-queue back to git.webkit.org

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We moved all EWS bots from git.webkit.org to github.com in http://trac.webkit.org/r271600. However, since then we have been seeing intermittent failures on commit-queue. We tried various fixes, e.g.:
- Added retries in https://commits.webkit.org/r273000
- Added git reset --hard HEAD command in https://commits.webkit.org/r275624
- Added various commands to add robustness in https://commits.webkit.org/r275853

Still, we are noticing issues on commit queue, e.g.: 
https://ews-build.webkit.org/#/builders/28/builds/11234
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date

https://ews-build.webkit.org/#/builders/28/builds/11227
Item already exists in filesystem: File 'LayoutTests/fast/images/image-extraction/image-overlay-with-selection-styles-expected.html' already exists


We should switch Commit-Queue back to git.webkit.org, so as to keep Commit-Queue is a reliably working state.

Note that these issues seems related to git-svn, so once WebKit moves to pure git repository, we don't expect these issues, and we can then switch Commit-Queue again to github.

[Aakash Jain]

Created attachment 426426 [details]
Patch

[Aakash Jain]

Created attachment 426545 [details]
Patch

[Aakash Jain]

Created attachment 426550 [details]
Patch

[Jonathan Bedard]

Comment on attachment 426550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426550&action=review

> Tools/CISupport/ews-build/steps.py:218
> +            self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])

What is "revision" expected to be? Because if it is an actual subversion revision, this won't work. If it's an identifier or hash, this will work

[Aakash Jain]

Comment on attachment 426550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426550&action=review

>> Tools/CISupport/ews-build/steps.py:218
>> +            self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])
> 
> What is "revision" expected to be? Because if it is an actual subversion revision, this won't work. If it's an identifier or hash, this will work

it's git hash.

[Aakash Jain]

Created attachment 426576 [details]
[fast-cq] Patch

[EWS]

Committed r276315 (236796@main): <https://commits.webkit.org/236796@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426576 [details].

[Aakash Jain]

Tested in https://ews-build.webkit-uat.org/#/builders/26/builds/2069

[Ling Ho]

rdar://76911197

[Aakash Jain]

Commit-Queue seems to be working very reliably since the transition to git.webkit.org.