Bug 224761 - Add more GPUProcess release logging to facilitate debugging
Summary: Add more GPUProcess release logging to facilitate debugging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-19 08:02 PDT by Chris Dumez
Modified: 2021-04-23 03:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2021-04-19 08:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-19 08:02:09 PDT 
Add more GPUProcess release logging to facilitate debugging.
Comment 1 Chris Dumez 2021-04-19 08:03:04 PDT 
Created attachment 426420 [details]
Patch
Comment 2 Darin Adler 2021-04-19 09:28:21 PDT 
Comment on attachment 426420 [details]
Patch

Is it ever a good idea to log pointer values in a release build?
Comment 3 Chris Dumez 2021-04-19 09:29:31 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 426420 [details]
> Patch
> 
> Is it ever a good idea to log pointer values in a release build?

This is our common pattern thus far. E.g.:
#define RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__)
#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__)
Comment 4 EWS 2021-04-19 09:46:51 PDT 
Committed r276257 (236739@main): <https://commits.webkit.org/236739@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426420 [details].
Comment 5 Ling Ho 2021-04-23 03:03:19 PDT 
rdar://76849207