Bug 224739 - [WPE] Allow defining custom repo and branch for Cog checkout
Summary: [WPE] Allow defining custom repo and branch for Cog checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-18 20:16 PDT by Lauro Moura
Modified: 2021-04-23 00:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2021-04-18 20:17 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Updated patch (8.57 KB, patch)
2021-04-19 13:09 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-04-18 20:16:41 PDT 
[WPE] Allow defining custom repo and branch for Cog checkout
Comment 1 Lauro Moura 2021-04-18 20:17:38 PDT 
Created attachment 426392 [details]
Patch
Comment 2 Lauro Moura 2021-04-18 20:26:41 PDT 
Comment on attachment 426392 [details]
Patch

The check in "use_cog" is not enough. A leftover cog binary from a previous build will lead to implying Cog is enabled.
Comment 3 Lauro Moura 2021-04-19 13:09:20 PDT 
Created attachment 426467 [details]
Updated patch

Updated version with WPE_BROWSER envvar to allow selecting between cog and minibrowser. Makes it easier to switch between both.
Comment 4 EWS 2021-04-21 02:57:20 PDT 
Committed r276355 (236833@main): <https://commits.webkit.org/236833@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426467 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-23 00:38:48 PDT 
<rdar://problem/77060233>