Bug 224730 – Fix interpolation of the rotate CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Fix interpolation of the rotate CSS property

[Antoine Quint]

Created attachment 426375 [details]
Patch

[Antoine Quint]

Created attachment 426376 [details]
Patch

[Dean Jackson]

Comment on attachment 426376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426376&action=review

> Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp:66
> +        auto x = static_cast<float>(op.m_x);
> +        auto y = static_cast<float>(op.m_y);
> +        auto z = static_cast<float>(op.m_z);
> +        auto length = std::hypot(x, y, z);
> +        return { x / length, y / length, z / length };

Use simd.h here.

auto v = simd_make_float3(static_cast<float>(op.m_x), static_cast<float>(op.m_y), static_cast<float>(op.m_z));
auto normalized = simd_normalize(v);
return { normalized.x, normalized.y, normalized.z };

Although you might also be able to use simd things through the whole function and avoid FloatPoint3D.

[Dean Jackson]

simd stuff is apple-specific

[Dean Jackson]

... maybe. other platforms might have versions. And I think it's becoming part of the C++ stdlib. Ask weinig.

[Dean Jackson]

Another option would be to add a normalize fn to FloatPoint3D.

[Antoine Quint]

(In reply to Dean Jackson from comment #6)
> Another option would be to add a normalize fn to FloatPoint3D.

There actually is one :)

[Antoine Quint]

Created attachment 426379 [details]
Patch for landing

[EWS]

Committed r276231 (236713@main): <https://commits.webkit.org/236713@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426379 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77110066>