Bug 224729 - [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
Summary: [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-18 01:41 PDT by Yusuke Suzuki
Modified: 2021-04-23 02:55 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.39 KB, patch)
2021-04-18 01:42 PDT, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-04-18 01:41:47 PDT 
[JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
Comment 1 Yusuke Suzuki 2021-04-18 01:42:09 PDT 
Created attachment 426374 [details]
Patch
Comment 2 Darin Adler 2021-04-18 14:02:23 PDT 
Comment on attachment 426374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review

> Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48
> +    : Watchpoint(Watchpoint::Type::LLIntPrototypeLoadAdaptiveStructure)
> +    , m_owner(nullptr)
> +    , m_bytecodeOffset(0)

Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD.
Comment 3 Yusuke Suzuki 2021-04-20 00:23:53 PDT 
Comment on attachment 426374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review

>> Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48
>> +    , m_bytecodeOffset(0)
> 
> Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD.

Yes, we cannot do that.
Comment 4 Yusuke Suzuki 2021-04-20 00:26:20 PDT 
Committed r276290 (236772@main): <https://commits.webkit.org/236772@main>
Comment 5 Ling Ho 2021-04-23 02:55:50 PDT 
rdar://76884672