Bug 224719 - Don't omit conic gradient starting angle when serializing when starting angle is under 0
Summary: Don't omit conic gradient starting angle when serializing when starting angle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 223892
  Show dependency tree / graph
 
Reported: 2021-04-17 09:14 PDT by Tim Nguyen (:ntim)
Modified: 2021-04-17 12:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2021-04-17 09:33 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2021-04-17 10:51 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-04-17 09:14:49 PDT 
Regressed by bug 223892

`conic-gradient(from -2deg, red, blue)` serializes to `conic-gradient(red, blue)` which is incorrect.
Comment 1 Radar WebKit Bug Importer 2021-04-17 09:14:57 PDT 
<rdar://problem/76800507>
Comment 2 Tim Nguyen (:ntim) 2021-04-17 09:33:02 PDT 
Created attachment 426333 [details]
Patch
Comment 3 EWS Watchlist 2021-04-17 09:33:54 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Tim Nguyen (:ntim) 2021-04-17 09:51:30 PDT 
https://github.com/web-platform-tests/wpt/pull/28562
Comment 5 Tim Nguyen (:ntim) 2021-04-17 10:51:56 PDT 
Created attachment 426337 [details]
Patch
Comment 6 EWS 2021-04-17 12:02:12 PDT 
Committed r276203 (236685@main): <https://commits.webkit.org/236685@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426337 [details].