Bug 224710 - REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
Summary: REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-16 20:35 PDT by Lauro Moura
Modified: 2021-04-24 15:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2021-04-16 20:36 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-04-16 20:35:50 PDT 
REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
Comment 1 Lauro Moura 2021-04-16 20:36:38 PDT 
Created attachment 426317 [details]
Patch
Comment 2 Alex Christensen 2021-04-16 21:01:19 PDT 
Comment on attachment 426317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426317&action=review

> Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:-77
> -    EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference));

Ah, yes.  I was wondering how I changed behavior, but I actually just changed the expectations to match the Cocoa expectations.  This changes the expectations back.
As mentioned in the original bug, you should probably have a discussion of how/when you want to disable it.
Comment 3 EWS 2021-04-16 22:04:07 PDT 
Committed r276195 (236677@main): <https://commits.webkit.org/236677@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426317 [details].
Comment 4 Radar WebKit Bug Importer 2021-04-24 15:08:17 PDT 
<rdar://problem/77110106>