Deploy Ref/RefPtr in Editor

[Ryosuke Niwa]

Deploy smart pointers in Editor.

[Ryosuke Niwa]

Created attachment 426305 [details]
Patch

[Ryosuke Niwa]

Created attachment 426308 [details]
Fixed release builds

[Wenson Hsieh]

Comment on attachment 426308 [details]
Fixed release builds

View in context: https://bugs.webkit.org/attachment.cgi?id=426308&action=review

r=mews

> Source/WebCore/editing/Editor.cpp:3674
> +    if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle())

Nit - I think this one can be `makeRef`.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196
> +    Editor& editor = frame->editor();

Nit - auto&?

[Ryosuke Niwa]

Thanks for the review!

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 426308 [details]
> Fixed release builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426308&action=review
> 
> r=mews
> 
> > Source/WebCore/editing/Editor.cpp:3674
> > +    if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle())
> 
> Nit - I think this one can be `makeRef`.

Fixed.

> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196
> > +    Editor& editor = frame->editor();
> 
> Nit - auto&?

Fixed.

[Ryosuke Niwa]

Created attachment 426310 [details]
Patch for landing

[EWS]

Committed r276191 (236673@main): <https://commits.webkit.org/236673@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426310 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77110110>