Deploy smart pointers in Editor.
Created attachment 426305 [details] Patch
Created attachment 426308 [details] Fixed release builds
Comment on attachment 426308 [details] Fixed release builds View in context: https://bugs.webkit.org/attachment.cgi?id=426308&action=review r=mews > Source/WebCore/editing/Editor.cpp:3674 > + if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle()) Nit - I think this one can be `makeRef`. > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196 > + Editor& editor = frame->editor(); Nit - auto&?
Thanks for the review! (In reply to Wenson Hsieh from comment #3) > Comment on attachment 426308 [details] > Fixed release builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426308&action=review > > r=mews > > > Source/WebCore/editing/Editor.cpp:3674 > > + if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle()) > > Nit - I think this one can be `makeRef`. Fixed. > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196 > > + Editor& editor = frame->editor(); > > Nit - auto&? Fixed.
Created attachment 426310 [details] Patch for landing
Committed r276191 (236673@main): <https://commits.webkit.org/236673@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426310 [details].
<rdar://problem/77110110>