WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224708
Deploy Ref/RefPtr in Editor
https://bugs.webkit.org/show_bug.cgi?id=224708
Summary
Deploy Ref/RefPtr in Editor
Ryosuke Niwa
Reported
2021-04-16 18:10:47 PDT
Deploy smart pointers in Editor.
Attachments
Patch
(42.26 KB, patch)
2021-04-16 18:27 PDT
,
Ryosuke Niwa
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Fixed release builds
(42.51 KB, patch)
2021-04-16 18:34 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Patch for landing
(42.50 KB, patch)
2021-04-16 18:59 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2021-04-16 18:27:26 PDT
Created
attachment 426305
[details]
Patch
Ryosuke Niwa
Comment 2
2021-04-16 18:34:32 PDT
Created
attachment 426308
[details]
Fixed release builds
Wenson Hsieh
Comment 3
2021-04-16 18:35:45 PDT
Comment on
attachment 426308
[details]
Fixed release builds View in context:
https://bugs.webkit.org/attachment.cgi?id=426308&action=review
r=mews
> Source/WebCore/editing/Editor.cpp:3674 > + if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle())
Nit - I think this one can be `makeRef`.
> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196 > + Editor& editor = frame->editor();
Nit - auto&?
Ryosuke Niwa
Comment 4
2021-04-16 18:56:01 PDT
Thanks for the review! (In reply to Wenson Hsieh from
comment #3
)
> Comment on
attachment 426308
[details]
> Fixed release builds > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=426308&action=review
> > r=mews > > > Source/WebCore/editing/Editor.cpp:3674 > > + if (auto startNode = makeRefPtr(range.startContainer()); startNode->hasEditableStyle()) > > Nit - I think this one can be `makeRef`.
Fixed.
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196 > > + Editor& editor = frame->editor(); > > Nit - auto&?
Fixed.
Ryosuke Niwa
Comment 5
2021-04-16 18:59:04 PDT
Created
attachment 426310
[details]
Patch for landing
EWS
Comment 6
2021-04-16 19:33:02 PDT
Committed
r276191
(
236673@main
): <
https://commits.webkit.org/236673@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 426310
[details]
.
Radar WebKit Bug Importer
Comment 7
2021-04-24 15:08:30 PDT
<
rdar://problem/77110110
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug