Bug 224703 - [macOS] Add additional logging to help identify SSO dialog dismissals
Summary: [macOS] Add additional logging to help identify SSO dialog dismissals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-16 16:22 PDT by Brent Fulgham
Modified: 2021-04-20 11:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2021-04-16 19:50 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2021-04-17 13:05 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-04-16 16:22:52 PDT 
We've seen some reports that AppSSO flows sometimes leave a stuck authentication sheet stuck on the display. This is extremely disruptive, since the sheet is app-modal, preventing other tabs from being used.

This patch adds some logging to try to identify when this condition happens, and what might cause it.
Comment 1 Radar WebKit Bug Importer 2021-04-16 16:23:13 PDT 
<rdar://problem/76783787>
Comment 2 Brent Fulgham 2021-04-16 19:50:47 PDT 
Created attachment 426313 [details]
Patch
Comment 3 Brent Fulgham 2021-04-17 13:05:45 PDT 
Created attachment 426343 [details]
Patch
Comment 4 Maciej Stachowiak 2021-04-19 22:42:23 PDT 
Comment on attachment 426343 [details]
Patch

r=me
Comment 5 EWS 2021-04-20 11:38:55 PDT 
Committed r276314 (236795@main): <https://commits.webkit.org/236795@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426343 [details].