Bug 22470 - remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
: remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Page Loading
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Darin Adler
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-24 15:18 PST by Darin Adler
Modified: 2008-11-24 15:32 PST (History)
0 users

See Also:


Attachments
patch (14.08 KB, patch)
2008-11-24 15:22 PST, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-11-24 15:18:46 PST
Looking at implementations of updateGlobalHistory, Qt is the only platform that uses the passed-in URL without also getting other data from the DocumentLoader. The Mac and Win platforms both get things like the page title from the DocumentLoader, and so they could just have easily gotten the URL that way too. I think that historically the URL was harder to get, but now there's the simple urlForHistory function that gives you just the right URL.

So I want to remove this argument.
Comment 1 Darin Adler 2008-11-24 15:22:58 PST
Created attachment 25455 [details]
patch
Comment 2 Darin Adler 2008-11-24 15:32:47 PST
http://trac.webkit.org/changeset/38732