Bug 224682 - Remove redundant renderObject in BreakingContext::handleText
Summary: Remove redundant renderObject in BreakingContext::handleText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-16 11:00 PDT by zalan
Modified: 2021-04-24 15:08 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2021-04-16 11:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (21.55 KB, patch)
2021-04-16 11:12 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-16 11:00:42 PDT
ssia
Comment 1 zalan 2021-04-16 11:02:17 PDT
Created attachment 426247 [details]
Patch
Comment 2 Darin Adler 2021-04-16 11:04:40 PDT
Comment on attachment 426247 [details]
Patch

I would name this local variable "renderer". Sure, its type is RenderText&, but the role of the object is "the renderer for the text we are handling".
Comment 3 zalan 2021-04-16 11:07:18 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 426247 [details]
> Patch
> 
> I would name this local variable "renderer". Sure, its type is RenderText&,
> but the role of the object is "the renderer for the text we are handling".
ok
Comment 4 zalan 2021-04-16 11:12:44 PDT
Created attachment 426249 [details]
Patch
Comment 5 EWS 2021-04-16 14:13:19 PDT
Committed r276169 (236656@main): <https://commits.webkit.org/236656@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426249 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-24 15:08:43 PDT
<rdar://problem/77110114>