Bug 224665 - [css-flexbox] Table layout disregards overriding height
Summary: [css-flexbox] Table layout disregards overriding height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 221473
  Show dependency tree / graph
 
Reported: 2021-04-16 05:34 PDT by Felipe Erias
Modified: 2021-04-24 15:05 PDT (History)
12 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2021-04-16 06:07 PDT, Felipe Erias 		no flags Details | Formatted Diff | Diff
Patch (4.89 KB, patch)
2021-04-18 23:35 PDT, Felipe Erias 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Erias 2021-04-16 05:34:54 PDT 
These two WPT tests fail because the overriding height set by the table's flex parent is being ignored:

imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-flex-cross-size.html
imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size.html
Comment 1 Felipe Erias 2021-04-16 06:07:52 PDT 
Created attachment 426213 [details]
Patch
Comment 2 Sergio Villar Senin 2021-04-16 08:08:49 PDT 
Comment on attachment 426213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426213&action=review

Looks good to me. I wonder, does it not fix any grid-layout width tables bug?

> Source/WebCore/ChangeLog:3
> +        Table layout takes overriding height into account

This is a nit, but bug title normally describes the issue and...

> Source/WebCore/ChangeLog:8
> +        RenderTable::layout applies the overriding height set by the element's parent.

ChangeLog body describes the fix. Don't be afraid to be verbose :)
Comment 3 Felipe Erias 2021-04-18 23:35:41 PDT 
Created attachment 426396 [details]
Patch
Comment 4 EWS 2021-04-19 01:39:11 PDT 
Committed r276240 (236722@main): <https://commits.webkit.org/236722@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426396 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-24 15:05:36 PDT 
<rdar://problem/77110064>