Bug 224659 - Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand
Summary: Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-16 01:09 PDT by Ryosuke Niwa
Modified: 2021-04-24 15:10 PDT (History)
10 users (show)

See Also:

Attachments
Patch (33.11 KB, patch)
2021-04-16 01:47 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (33.16 KB, patch)
2021-04-16 02:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-04-16 01:09:47 PDT 
Deploy smart pointers.
Comment 1 Ryosuke Niwa 2021-04-16 01:47:08 PDT 
Created attachment 426197 [details]
Patch
Comment 2 Antti Koivisto 2021-04-16 02:44:03 PDT 
Comment on attachment 426197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426197&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1013
> +    ([&]() {

Are the parethesis necessary? I think just doing

[&] {
  ...
}();

works.
Comment 3 Antti Koivisto 2021-04-16 02:46:30 PDT 
Also you could consider making it an informatively named lambda, just for documentation purposes.
Comment 4 Ryosuke Niwa 2021-04-16 02:46:53 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 426197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426197&action=review
> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:1013
> > +    ([&]() {
> 
> Are the parethesis necessary? I think just doing
> 
> [&] {
>   ...
> }();
> 
> works.

That's a good point. Will change.
Comment 5 Ryosuke Niwa 2021-04-16 02:55:52 PDT 
Created attachment 426200 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2021-04-16 02:55:57 PDT 
(In reply to Antti Koivisto from comment #3)
> Also you could consider making it an informatively named lambda, just for
> documentation purposes.

Will do.
Comment 7 EWS 2021-04-16 03:21:52 PDT 
Committed r276131 (236626@main): <https://commits.webkit.org/236626@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426200 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-24 15:10:00 PDT 
<rdar://problem/77110130>