Bug 224659 – Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

Deploy smart pointers.

[Ryosuke Niwa]

Created attachment 426197 [details]
Patch

[Antti Koivisto]

Comment on attachment 426197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426197&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1013
> +    ([&]() {

Are the parethesis necessary? I think just doing

[&] {
  ...
}();

works.

[Antti Koivisto]

Also you could consider making it an informatively named lambda, just for documentation purposes.

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 426197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426197&action=review
> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:1013
> > +    ([&]() {
> 
> Are the parethesis necessary? I think just doing
> 
> [&] {
>   ...
> }();
> 
> works.

That's a good point. Will change.

[Ryosuke Niwa]

Created attachment 426200 [details]
Patch for landing

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #3)
> Also you could consider making it an informatively named lambda, just for
> documentation purposes.

Will do.

[EWS]

Committed r276131 (236626@main): <https://commits.webkit.org/236626@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426200 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77110130>