Bug 224657 - [GLIB] imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https.html is failing
Summary: [GLIB] imported/w3c/web-platform-tests/service-workers/service-worker/next-ho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-16 00:40 PDT by Diego Pino
Modified: 2022-02-07 21:32 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-04-16 00:40:01 PDT 
The test was removed in r276009 as it was solved. However, r276009 was partially reverted in r276021 and since then this test is failing again. The test should be reintroduced in glib TestExpectations.

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r276100%20%281194%29/imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https-actual.txt
@@ -1,4 +1,4 @@
 
-FAIL nextHopProtocol reports H1 correctly when routed via a service worker. assert_equals: nextHopProtocol is set on pass-through expected "http/1.1" but got ""
+FAIL nextHopProtocol reports H1 correctly when routed via a service worker. assert_equals: nextHopProtocol is set on cached response expected "http/1.1" but got ""
 FAIL nextHopProtocol reports H2 correctly when routed via a service worker. assert_equals: nextHopProtocol is set on fallback expected "h2" but got "http/1.1"
Comment 1 Diego Pino 2021-04-16 00:49:21 PDT 
Reintroduced test failure in r276122.
Comment 2 Radar WebKit Bug Importer 2021-04-23 01:10:24 PDT 
<rdar://problem/77061210>
Comment 3 Carlos Garcia Campos 2021-06-03 05:19:51 PDT 
I don't understand how this could work before or why it works in mac, because ServiceWorkerFetchTask::didFinish() always passes an empty metrics to Messages::WebResourceLoader::DidFinishResourceLoad(). Any idea Alex?
Comment 4 Diego Pino 2022-02-07 21:32:19 PST 
Fixed by r288088. Closing bug.