RESOLVED FIXED22465
Define KURL::copy() and use it in WorkerThread.cpp 
https://bugs.webkit.org/show_bug.cgi?id=22465
Summary Define KURL::copy() and use it in WorkerThread.cpp
Darin Fisher (:fishd, Google)
Reported 2008-11-24 13:20:01 PST
Define KURL::copy() and use it in WorkerThread.cpp It would be handy to have a "deep copy" function on KURL to avoid re-parsing when passing a KURL to a background thread.
Attachments
v1 patch (2.23 KB, patch)
2008-11-24 15:25 PST, Darin Fisher (:fishd, Google) 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2008-11-24 15:25:10 PST
Created attachment 25456 [details] v1 patch
Geoffrey Garen
Comment 2 2008-11-24 22:14:31 PST
Comment on attachment 25456 [details] v1 patch "deepCopy" might be a better name for conveying that you shouldn't call this function if you don't mean it. Then you can remove this part of you comment, too: // Makes a deep copy. r=me
Adam Barth
Comment 3 2008-11-24 22:19:26 PST
There is some value in being consistent with other classes. Should we change SecurityOrigin::copy to be deepCopy as well?
Darin Fisher (:fishd, Google)
Comment 4 2008-11-24 22:31:03 PST
What about String::copy()? I was just replicating that. Notice that my comments are very similar to the comments above String::copy()! Should we change them all?
Darin Fisher (:fishd, Google)
Comment 5 2008-11-24 22:48:32 PST
http://trac.webkit.org/changeset/38746 Per discussion on #webkit, I'm going to file a follow-up bug to consider renaming all of these 'copy' methods to 'deepCopy'.
Darin Fisher (:fishd, Google)
Comment 6 2008-11-24 22:51:49 PST
Please see https://bugs.webkit.org/show_bug.cgi?id=22479 for the follow-up bug.
Note You need to log in before you can comment on or make changes to this bug.