Bug 224649 - WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107
Summary: WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file n...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on: 224469
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-15 23:15 PDT by Fujii Hironori
Modified: 2021-04-16 01:10 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2021-04-15 23:17 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-04-15 23:15:00 PDT 
WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107

r276107 (236607@main)

> [4971/5700] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp.obj
> FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/WebKit/DerivedSources/RemoteMediaPlayerProxyMessageReceiver.cpp.obj 
> C:\PROGRA~1\LLVM\bin\clang-cl.exe (...) -c WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp
> In file included from WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp:46:
> ..\..\Source\WebKit\Shared\WebCoreArgumentCoders.h(36,10): fatal error: 'WebCore/MediaPlaybackTargetContext.h' file not found
> #include <WebCore/MediaPlaybackTargetContext.h>
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
Comment 1 Fujii Hironori 2021-04-15 23:17:24 PDT 
Created attachment 426186 [details]
Patch
Comment 2 Peng Liu 2021-04-15 23:25:24 PDT 
Thanks for the fix!
Comment 3 Fujii Hironori 2021-04-15 23:33:34 PDT 
This fix isn't enough. More errors.

WebKitBuild\Debug\WebKit\DerivedSources\WebPageProxyMessages.h(65): fatal error C1083: Cannot open include file: 'WebCore/MediaPlaybackTargetContext.h': No such file or directory
Comment 4 Fujii Hironori 2021-04-15 23:43:08 PDT 
Umm, <WebCore/MediaPlaybackTargetContext.h> is included from the derived source. Can I revert your r276107?
Comment 5 Fujii Hironori 2021-04-15 23:56:34 PDT 
I'm sorry. It isn't easy to fix the build error.
r276120 reverted your r276107.
It broke only clean builds. Feel free to ask me try clean builds if you need.
Comment 6 Peng Liu 2021-04-16 01:10:33 PDT 
Does it break windows port only?