Bug 224632 – Use kIOMainPortDefault where available

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Replace deprecation pragmas with new port name

[Alex Christensen]

Created attachment 426157 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Alex Christensen]

Created attachment 426165 [details]
Patch

[Alex Christensen]

Created attachment 426166 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 426166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426166&action=review

I would probably centralize this in one place if I were doing this, but seems OK either way.

> Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:41
>  #pragma clang diagnostic ignored "-Wdeprecated-declarations"

You can consider adding comments saying that the pragmas can be removed once rdar://76706593 is fixed, but it's not terribly important.

[EWS]

Committed r276104 (236604@main): <https://commits.webkit.org/236604@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426166 [details].

[Kimmo Kinnunen]

Not sure if I'm doing something wrong, but I'm seeing the inverse issue now with an older SDK.

CompileC SystemInfo_macos.o
/Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:38:34: error: use of undeclared identifier 'kIOMainPortDefault'
    const mach_port_t mainPort = kIOMainPortDefault;
                                 ^
/Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:109:38: error: use of undeclared identifier 'kIOMainPortDefault'
        const mach_port_t mainPort = kIOMainPortDefault;
                                     ^
/Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:176:34: error: use of undeclared identifier 'kIOMainPortDefault'
    const mach_port_t mainPort = kIOMainPortDefault;
                                 ^
/Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:285:38: error: use of undeclared identifier 'kIOMainPortDefault'
        const mach_port_t mainPort = kIOMainPortDefault;
                                     ^

[Alex Christensen]

(In reply to Kimmo Kinnunen from comment #7)
> Not sure if I'm doing something wrong, but I'm seeing the inverse issue now
> with an older SDK.
Time to update your SDK.

[Radar WebKit Bug Importer]

<rdar://problem/77110140>