Bug 224630 – [PlayStation][OpenSSL] Remove warnings.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

There're two kinds of warnings in curl and openssl layer in our platform.

a) Unused param

b) '__WORDSIZE' is not defined. 
[2530/5050] Building CXX object Source/WebCore/CM...es/unified-sources/UnifiedSource-44a97133-1.cpp.oIn file included from WebCore/DerivedSources/unified-sources/UnifiedSource-44a97133-1.cpp:8:
../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:42:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef]
#if __WORDSIZE >= 64
    ^
../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:80:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef]
#if __WORDSIZE >= 64
    ^
../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:123:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef]
#if __WORDSIZE >= 64
    ^
3 warnings generated.

[Basuke Suzuki]

Created attachment 426159 [details]
PATCH

[Stephan Szabo]

Comment on attachment 426159 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=426159&action=review

> Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp:36
> +RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier, CryptoAlgorithmIdentifier, bool hasHash, const CryptoKeyRSAComponents&, bool extractable, CryptoKeyUsageBitmap)

Is there a reason to remove just one argument's name here and then use UNUSED_PARAM for the others arguments? It seems like it'd be better to be consistent.

[Basuke Suzuki]

Created attachment 426169 [details]
PATCH

[Basuke Suzuki]

Comment on attachment 426159 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=426159&action=review

>> Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp:36
>> +RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier, CryptoAlgorithmIdentifier, bool hasHash, const CryptoKeyRSAComponents&, bool extractable, CryptoKeyUsageBitmap)
> 
> Is there a reason to remove just one argument's name here and then use UNUSED_PARAM for the others arguments? It seems like it'd be better to be consistent.

I follow style guideline that if the argument is described enough by type, then it should be omitted if possible. On the other hand, bool, int or such general type is not.

[Stephan Szabo]

(In reply to Basuke Suzuki from comment #4)
> Comment on attachment 426159 [details]
> PATCH
> 
> I follow style guideline that if the argument is described enough by type,
> then it should be omitted if possible. On the other hand, bool, int or such
> general type is not.

Okay, that seems like a reasonable division. :)

[EWS]

Committed r276167 (236654@main): <https://commits.webkit.org/236654@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426169 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77110115>