WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224620
webkitpy classes need not define loads/dumps helpers for pickle
https://bugs.webkit.org/show_bug.cgi?id=224620
Summary
webkitpy classes need not define loads/dumps helpers for pickle
Sam Sneddon [:gsnedders]
Reported
2021-04-15 13:34:41 PDT
These have little advantage versus calling pickle directly (and lack some of the options), and are only used by the tests to ensure certain classes round-trip.
Attachments
Patch
(6.64 KB, patch)
2021-04-15 13:37 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2021-04-15 13:37:51 PDT
Created
attachment 426132
[details]
Patch
EWS
Comment 2
2021-04-15 15:44:37 PDT
Committed
r276081
(
236593@main
): <
https://commits.webkit.org/236593@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 426132
[details]
.
Ryan Haddad
Comment 3
2021-04-15 15:59:38 PDT
rdar://76727229
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug