Bug 224620 - webkitpy classes need not define loads/dumps helpers for pickle
Summary: webkitpy classes need not define loads/dumps helpers for pickle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-15 13:34 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-15 15:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2021-04-15 13:37 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-15 13:34:41 PDT 
These have little advantage versus calling pickle directly (and lack some of the options), and are only used by the tests to ensure certain classes round-trip.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-15 13:37:51 PDT 
Created attachment 426132 [details]
Patch
Comment 2 EWS 2021-04-15 15:44:37 PDT 
Committed r276081 (236593@main): <https://commits.webkit.org/236593@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426132 [details].
Comment 3 Ryan Haddad 2021-04-15 15:59:38 PDT 
rdar://76727229