Bug 224619 - Optimize the DeferTermination scope to be more efficient.
Summary: Optimize the DeferTermination scope to be more efficient.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 224610
  Show dependency tree / graph
 
Reported: 2021-04-15 12:57 PDT by Mark Lam
Modified: 2021-04-22 17:31 PDT (History)
10 users (show)

See Also:

Attachments
proposed patch. (14.72 KB, patch)
2021-04-15 13:06 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-15 12:57:29 PDT 
This can be beneficial since we may be using DeferTermination in more places.
Comment 1 Mark Lam 2021-04-15 13:06:10 PDT 
Created attachment 426129 [details]
proposed patch.
Comment 2 Saam Barati 2021-04-15 13:26:15 PDT 
Comment on attachment 426129 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=426129&action=review

> Source/JavaScriptCore/ChangeLog:23
> +           Except for VMTraps::m_trapBits, all of these are only written to fro the mutator

fro => from
Comment 3 Mark Lam 2021-04-15 13:31:47 PDT 
Thanks for the review.  Landed in r276069: <http://trac.webkit.org/r276069>.
Comment 4 Mark Lam 2021-04-15 13:47:07 PDT 
rdar://76718772
Comment 5 Mark Lam 2021-04-16 00:30:58 PDT 
Build fix landed in r276121: <http://trac.webkit.org/r276121>.
Comment 6 Ryan Haddad 2021-04-22 17:31:54 PDT 
rdar://76718772