Bug 224592 - Add missing exception check in operationGetPrivateNameOptimize().
Summary: Add missing exception check in operationGetPrivateNameOptimize().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 22:29 PDT by Mark Lam
Modified: 2021-04-14 22:54 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (2.79 KB, patch)
2021-04-14 22:39 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-14 22:29:23 PDT 
rdar://76645873
Comment 1 Mark Lam 2021-04-14 22:39:01 PDT 
Created attachment 426075 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-04-14 22:45:48 PDT 
Comment on attachment 426075 [details]
proposed patch.

r=me
Comment 3 Yusuke Suzuki 2021-04-14 22:46:12 PDT 
Comment on attachment 426075 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=426075&action=review

> Source/JavaScriptCore/jit/JITOperations.cpp:2407
> +        EXCEPTION_ASSERT(!scope.exception() || vm.isTerminationException(scope.exception()));

We discussed and left this assertion for documentation purpose.
Comment 4 Mark Lam 2021-04-14 22:54:28 PDT 
Thanks for the review.  Landed in r276000: <http://trac.webkit.org/r276000>.