RESOLVED FIXED Bug 224592
Add missing exception check in operationGetPrivateNameOptimize().
https://bugs.webkit.org/show_bug.cgi?id=224592
Summary Add missing exception check in operationGetPrivateNameOptimize().
Mark Lam
Reported 2021-04-14 22:29:23 PDT
Attachments
proposed patch. (2.79 KB, patch)
2021-04-14 22:39 PDT, Mark Lam
ysuzuki: review+
Mark Lam
Comment 1 2021-04-14 22:39:01 PDT
Created attachment 426075 [details] proposed patch.
Yusuke Suzuki
Comment 2 2021-04-14 22:45:48 PDT
Comment on attachment 426075 [details] proposed patch. r=me
Yusuke Suzuki
Comment 3 2021-04-14 22:46:12 PDT
Comment on attachment 426075 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=426075&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2407 > + EXCEPTION_ASSERT(!scope.exception() || vm.isTerminationException(scope.exception())); We discussed and left this assertion for documentation purpose.
Mark Lam
Comment 4 2021-04-14 22:54:28 PDT
Thanks for the review. Landed in r276000: <http://trac.webkit.org/r276000>.
Note You need to log in before you can comment on or make changes to this bug.