Bug 224583 - Fix WK_EXPORT macro for declspec compilers
Summary: Fix WK_EXPORT macro for declspec compilers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 16:19 PDT by Basuke Suzuki
Modified: 2021-04-14 19:43 PDT (History)
4 users (show)

See Also:

Attachments
PATCH (1.53 KB, patch)
2021-04-14 17:43 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-04-14 16:19:38 PDT 
There're lots of warnings while building WebKit on those which uses declspec.

> WebKit/Headers\WebKit/WKDeclarationSpecifiers.h:38:5: warning: 'BUILDING_WebKit' is not defined, evaluates to 0 [-Wundef]
> #if BUILDING_WebKit
>     ^
> 1 warning generated.
Comment 1 Basuke Suzuki 2021-04-14 17:43:21 PDT 
Created attachment 426064 [details]
PATCH
Comment 2 EWS 2021-04-14 19:42:17 PDT 
Committed r275992 (236544@main): <https://commits.webkit.org/236544@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426064 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-14 19:43:20 PDT 
<rdar://problem/76680054>