Bug 22458 – [wx] wxWebView lacks a "find string" API

Bug 22458 - [wx] wxWebView lacks a "find string" API


Summary:	[wx] wxWebView lacks a "find string" API

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	WebKit wx
Version:	528+ (Nightly build)
Platform:	PC All

Importance:	P2 Normal
Assigned To:	Nobody

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-11-24 11:08 PST by Kevin Watters
Modified:	2008-12-13 09:51 PST (History)
CC List:	0 users

See Also:

Attachments
implements wxWebView::FindString (1.56 KB, patch) 2008-11-24 11:08 PST, Kevin Watters	kevino: review-	Details \| Formatted Diff \| Diff
fixed wxWebView::FindString patch (2.73 KB, patch) 2008-12-02 15:20 PST, Kevin Watters	kevino: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Watters 2008-11-24 11:08:09 PST

There is no simple API to find strings in a wxWebView.

Comment 1 Kevin Watters 2008-11-24 11:08:46 PST

Created attachment 25436 [details]
implements wxWebView::FindString

Comment 2 Kevin Ollivier 2008-12-02 09:40:29 PST

r- because this patch only works with the wxWebView's main frame. Even though we don't currently support multiple frames, we're close to having that implemented, and so I would like all new functionality that calls frame methods to go in wxWebFrame rather than wxWebView.

Comment 3 Kevin Watters 2008-12-02 15:20:05 PST

Created attachment 25688 [details]
fixed wxWebView::FindString patch

Implements wxWebFrame::FindString. Places frame functionality in wxWebFrame, not wxWebView.

Comment 4 Kevin Ollivier 2008-12-13 09:51:32 PST

Landed in r39273, thanks!