Bug 224572 - Apply DeferTermination in some utility functions in the jsc shell.
Summary: Apply DeferTermination in some utility functions in the jsc shell.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 12:44 PDT by Mark Lam
Modified: 2021-04-20 01:22 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.82 KB, patch)
2021-04-14 13:47 PDT, Mark Lam 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-14 12:44:16 PDT 
This is to make sure that these functions don't get in the way of testing with the watchdog.  Since these are only test utility functions, just doing the simple thing of using a DeferTermination scope is the right thing to do here.
Comment 1 Mark Lam 2021-04-14 12:44:43 PDT 
rdar://76646089
Comment 2 Mark Lam 2021-04-14 13:47:59 PDT 
Created attachment 426042 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2021-04-14 13:50:15 PDT 
Comment on attachment 426042 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2021-04-14 13:52:19 PDT 
Comment on attachment 426042 [details]
proposed patch.

Thanks for the review.
Comment 5 Mark Lam 2021-04-14 14:52:50 PDT 
Closed the wrong bug: too many browser tabs going at the same time.  Sorry.
Comment 6 Mark Lam 2021-04-14 14:58:20 PDT 
I added the comment in the description above in the ChangeLog before landing.

Landed in r275971: <http://trac.webkit.org/r275971>.