Bug 224558 - [ wk2 ] 2 page-cache layout-tests are flakey crashing
Summary: [ wk2 ] 2 page-cache layout-tests are flakey crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 10:31 PDT by Robert Jenner
Modified: 2021-10-19 07:17 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.63 KB, patch)
2021-10-18 04:15 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (6.76 KB, patch)
2021-10-18 05:24 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2021-10-18 07:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-04-14 10:31:08 PDT
The following two tests are flakey crashing for wk2 on iOS Simulator 14 Debug, and macOS Catalina and Big Sur. 

webrtc/peerconnection-new-candidate-page-cache.html 
http/tests/navigation/page-cache-mediastream.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=webrtc%2Fpeerconnection-new-candidate-page-cache.html&test=http%2Ftests%2Fnavigation%2Fpage-cache-mediastream.html

Grouping these together because they appear to have similar crash history, and started crashing all at the same revision (r275928)

Crashlogs could not be generated for some reason. Will attempt to gather them when I attempt to reproduce.
Comment 1 Radar WebKit Bug Importer 2021-04-14 10:31:29 PDT
<rdar://problem/76652825>
Comment 2 Robert Jenner 2021-04-14 10:41:51 PDT
Updated test expectations to Pass Crash here:
https://trac.webkit.org/changeset/275951/webkit

Crashing was having a negative impact on EWS and commit queue, which is why I updated the expectations before investigating and reproducing.
Comment 3 youenn fablet 2021-04-19 01:40:37 PDT
Does not crash anymore after https://results.webkit.org/commit?branch=main&uuid=161847222600
Comment 4 youenn fablet 2021-10-18 04:15:32 PDT
Reopening to attach new patch.
Comment 5 youenn fablet 2021-10-18 04:15:35 PDT
Created attachment 441582 [details]
Patch
Comment 6 youenn fablet 2021-10-18 05:24:59 PDT
Created attachment 441592 [details]
Patch
Comment 7 youenn fablet 2021-10-18 07:16:30 PDT
Created attachment 441599 [details]
Patch
Comment 8 EWS 2021-10-19 07:17:34 PDT
Committed r284449 (243209@main): <https://commits.webkit.org/243209@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441599 [details].