Bug 224557 - [Nicosia] NicosiaGCGLLayer is unneeded when ENABLE_WEBGL is OFF
Summary: [Nicosia] NicosiaGCGLLayer is unneeded when ENABLE_WEBGL is OFF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 10:25 PDT by Don Olmstead
Modified: 2021-04-14 23:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2021-04-14 10:28 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (2.16 KB, patch)
2021-04-14 10:30 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-04-14 10:25:45 PDT 
No GCGL means no need for a layer for it in Nicosia.
Comment 1 Don Olmstead 2021-04-14 10:28:38 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-04-14 10:30:02 PDT 
Created attachment 426001 [details]
Patch
Comment 3 Michael Catanzaro 2021-04-14 14:22:39 PDT 
Comment on attachment 426001 [details]
Patch

No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder!
Comment 4 Don Olmstead 2021-04-14 18:57:37 PDT 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 426001 [details]
> Patch
> 
> No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder!

Trying again cause there’s no way this would break Mac
Comment 5 EWS 2021-04-14 20:50:59 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
Comment 6 Don Olmstead 2021-04-14 21:00:45 PDT 
(In reply to EWS from comment #5)
> Found 1 new test failure:
> imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-
> structured-data/messagechannel.any.html

This patch is cursed....
Comment 7 EWS 2021-04-14 22:55:43 PDT 
Committed r276001 (236553@main): <https://commits.webkit.org/236553@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426001 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-14 22:56:14 PDT 
<rdar://problem/76686280>