Bug 224511 – Move cloneUBreakIterator declaration to IntlWorkaround.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

Move cloneUBreakIterator declaration to IntlWorkaround.h

[Ross Kirsling]

Created attachment 425915 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 425915 [details]
Patch

r=me

[Darin Adler]

Comment on attachment 425915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425915&action=review

> Source/JavaScriptCore/runtime/IntlSegmenter.h:29
> +#include "IntlWorkaround.h"

This include should be added to the two .cpp files that use it, not to a header.

Also, don’t forget to remove the declaration of cloneUBreakIterator from this header.

> Source/JavaScriptCore/runtime/IntlWorkaround.h:28
> +#include <unicode/utypes.h>

It’s possible we could use a forward declaration for this too:

    typedef enum UErrorCode UErrorCode;

But not an important optimization, so never mind.

[Darin Adler]

Oops, bugs.webkit.org overwrite Yusuke's review flag with a darin? flag. Not intentional.

[Ross Kirsling]

Created attachment 425925 [details]
Patch

[Ross Kirsling]

Created attachment 425926 [details]
Patch for landing

[Ross Kirsling]

(In reply to Darin Adler from comment #3)
> > Source/JavaScriptCore/runtime/IntlWorkaround.h:28
> > +#include <unicode/utypes.h>
> 
> It’s possible we could use a forward declaration for this too:
> 
>     typedef enum UErrorCode UErrorCode;
> 
> But not an important optimization, so never mind.

Yeah, I wanted to do so, but clang gave me "error: ISO C++ forbids forward references to 'enum' types".

[EWS]

Committed r275920 (236483@main): <https://commits.webkit.org/236483@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425926 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76618968>