Bug 224506 - InlineBox should not hold a reference to RenderObject
Summary: InlineBox should not hold a reference to RenderObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 12:51 PDT by zalan
Modified: 2021-04-14 06:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.99 KB, patch)
2021-04-13 13:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-13 12:51:04 PDT 
The InlineBox/RenderObject relationship is rather complicated (see RenderBox::setInlineBoxWrapper() vs. InlineElementBox::extractLine) and it's easy to delete one without letting the other know.
Comment 1 zalan 2021-04-13 13:01:27 PDT 
Created attachment 425905 [details]
Patch
Comment 2 EWS 2021-04-14 06:57:21 PDT 
Committed r275943 (236505@main): <https://commits.webkit.org/236505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425905 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-14 06:58:15 PDT 
<rdar://problem/76643802>