Bug 224497 - [build.webkit.org] run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org
Summary: [build.webkit.org] run-javascriptcore-tests should report commit identifier i...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 11:29 PDT by Aakash Jain
Modified: 2021-05-12 15:10 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-04-13 11:29:43 PDT 
On build.webkit.org run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org.

Current logic seems to be finding the revision/hash using commitForDirectory() method in https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/VCSUtils.pm#L382. We can update that logic to return commit identifier.

Other options are:
- run-javascriptcore-tests script can accept a parameter named commit-identifier/ref and buildbot can pass that parameter based on 'identifier' build property.
- do nothing, when we move build.webkit.org bots to git, run-javascriptcore-tests will start reporting git hash to results.webkit.org
Comment 1 Radar WebKit Bug Importer 2021-04-20 11:30:24 PDT 
<rdar://problem/76907517>