WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
224497
[build.webkit.org] run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=224497
Summary
[build.webkit.org] run-javascriptcore-tests should report commit identifier i...
Aakash Jain
Reported
2021-04-13 11:29:43 PDT
On build.webkit.org run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org. Current logic seems to be finding the revision/hash using commitForDirectory() method in
https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/VCSUtils.pm#L382
. We can update that logic to return commit identifier. Other options are: - run-javascriptcore-tests script can accept a parameter named commit-identifier/ref and buildbot can pass that parameter based on 'identifier' build property. - do nothing, when we move build.webkit.org bots to git, run-javascriptcore-tests will start reporting git hash to results.webkit.org
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-04-20 11:30:24 PDT
<
rdar://problem/76907517
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug