Bug 224494 - The watchdog should not fire when it's not active.
Summary: The watchdog should not fire when it's not active.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 11:12 PDT by Mark Lam
Modified: 2021-04-13 19:20 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.82 KB, patch)
2021-04-13 11:16 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (1.95 KB, patch)
2021-04-13 11:20 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (2.55 KB, patch)
2021-04-13 14:57 PDT, Mark Lam 		saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-13 11:12:26 PDT 
This is needed because JSValue::toWTFStringSlowCase() can throw exceptions and do many other VM operations.

rdar://76581259
Comment 1 Mark Lam 2021-04-13 11:16:23 PDT 
Created attachment 425886 [details]
proposed patch.
Comment 2 Mark Lam 2021-04-13 11:20:22 PDT 
Created attachment 425887 [details]
proposed patch.
Comment 3 Mark Lam 2021-04-13 14:57:09 PDT 
Created attachment 425919 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2021-04-13 15:04:14 PDT 
Comment on attachment 425919 [details]
proposed patch.

r=me too.
Comment 5 Mark Lam 2021-04-13 19:17:08 PDT 
The mac-AS-debug-wk2 failure is unrelated.
Comment 6 Mark Lam 2021-04-13 19:20:14 PDT 
Thanks for the reviews.  Landed in r275924: <http://trac.webkit.org/r275924>.