Bug 224490 - Use a JSString for the TerminationException value instead of a Symbol.
Summary: Use a JSString for the TerminationException value instead of a Symbol.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 09:57 PDT by Mark Lam
Modified: 2021-04-13 12:58 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.98 KB, patch)
2021-04-13 11:02 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-13 09:57:04 PDT 
This makes it convertible to a String for clients that wish to report the exception.  Clients, in this case, does not apply to JS code, only C++ code that catches the exception at the outermost point to handle the termination.  The TerminationException value is not visible to JS code because the TerminationException cannot be caught.  So, this change is transparent to JS code.
Comment 1 Mark Lam 2021-04-13 11:02:36 PDT 
Created attachment 425885 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-04-13 11:43:25 PDT 
Comment on attachment 425885 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2021-04-13 12:37:33 PDT 
Comment on attachment 425885 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 EWS 2021-04-13 12:57:03 PDT 
Committed r275902 (236467@main): <https://commits.webkit.org/236467@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425885 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-13 12:58:15 PDT 
<rdar://problem/76605985>