Bug 22449 - Implement repatching for get by id chain.
Summary: Implement repatching for get by id chain.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-24 01:38 PST by Gavin Barraclough
Modified: 2008-11-24 02:29 PST (History)
0 users

See Also:


Attachments
The patch (5.80 KB, patch)
2008-11-24 01:38 PST, Gavin Barraclough
zwarich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-11-24 01:38:21 PST
Will be a 3% progression on deltablue.
Comment 1 Gavin Barraclough 2008-11-24 01:38:44 PST
Created attachment 25417 [details]
The patch
Comment 2 Cameron Zwarich (cpst) 2008-11-24 01:50:46 PST
Comment on attachment 25417 [details]
The patch

Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well.

>     for (unsigned i = 0; i<count; ++i) {

There should be spaces on either side of '<'.

I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch.

r=me
Comment 3 Cameron Zwarich (cpst) 2008-11-24 01:50:46 PST
Comment on attachment 25417 [details]
The patch

Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well.

>     for (unsigned i = 0; i<count; ++i) {

There should be spaces on either side of '<'.

I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch.

r=me
Comment 4 Gavin Barraclough 2008-11-24 02:29:08 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/jit/JIT.cpp
Transmitting file data ..
Committed revision 38700.