WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22449
Implement repatching for get by id chain.
https://bugs.webkit.org/show_bug.cgi?id=22449
Summary
Implement repatching for get by id chain.
Gavin Barraclough
Reported
2008-11-24 01:38:21 PST
Will be a 3% progression on deltablue.
Attachments
The patch
(5.80 KB, patch)
2008-11-24 01:38 PST
,
Gavin Barraclough
zwarich
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2008-11-24 01:38:44 PST
Created
attachment 25417
[details]
The patch
Cameron Zwarich (cpst)
Comment 2
2008-11-24 01:50:46 PST
Comment on
attachment 25417
[details]
The patch Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well.
> for (unsigned i = 0; i<count; ++i) {
There should be spaces on either side of '<'. I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch. r=me
Cameron Zwarich (cpst)
Comment 3
2008-11-24 01:50:46 PST
Comment on
attachment 25417
[details]
The patch Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well.
> for (unsigned i = 0; i<count; ++i) {
There should be spaces on either side of '<'. I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch. r=me
Gavin Barraclough
Comment 4
2008-11-24 02:29:08 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/JIT.cpp Transmitting file data .. Committed revision 38700.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug