Bug 224485 - Web Inspector: Forced color scheme should reset on page refresh
Summary: Web Inspector: Forced color scheme should reset on page refresh
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 06:34 PDT by Razvan Caliman
Modified: 2021-04-26 16:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2021-04-13 07:11 PDT, Razvan Caliman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Razvan Caliman 2021-04-13 06:34:08 PDT 
<rdar://76227216>
Comment 1 Razvan Caliman 2021-04-13 07:11:48 PDT 
Created attachment 425871 [details]
Patch
Comment 2 BJ Burg 2021-04-13 12:38:05 PDT 
Comment on attachment 425871 [details]
Patch

r=me
Comment 3 EWS 2021-04-13 13:09:41 PDT 
Committed r275904 (236468@main): <https://commits.webkit.org/236468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425871 [details].
Comment 4 Yury Semikhatsky 2021-04-26 16:12:35 PDT 
(In reply to EWS from comment #3)
> Committed r275904 (236468@main): <https://commits.webkit.org/236468@main>
> 

This change regresses current behavior: there is no way to override color scheme preference in the early stage of page load as there is inherent delay between navigation commit and when the front-end can set the override back. Basically this code will always give wrong result if run early during page load:

// Send Page.setForcedAppearance with "appearance":"Light"
// navigate to a page with the following code in its inline script:
console.log(matchMedia('(prefers-color-scheme: light)').matches);