Bug 224485 – Web Inspector: Forced color scheme should reset on page refresh

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Web Inspector

[Razvan Caliman]

<rdar://76227216>

[Razvan Caliman]

Created attachment 425871 [details]
Patch

[Blaze Burg]

Comment on attachment 425871 [details]
Patch

r=me

[EWS]

Committed r275904 (236468@main): <https://commits.webkit.org/236468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425871 [details].

[Yury Semikhatsky]

(In reply to EWS from comment #3)
> Committed r275904 (236468@main): <https://commits.webkit.org/236468@main>
> 

This change regresses current behavior: there is no way to override color scheme preference in the early stage of page load as there is inherent delay between navigation commit and when the front-end can set the override back. Basically this code will always give wrong result if run early during page load:

// Send Page.setForcedAppearance with "appearance":"Light"
// navigate to a page with the following code in its inline script:
console.log(matchMedia('(prefers-color-scheme: light)').matches);

[Razvan Caliman]

(In reply to Yury Semikhatsky from comment #4)
> This change regresses current behavior: there is no way to override color
> scheme preference in the early stage of page load as there is inherent delay
> between navigation commit and when the front-end can set the override back.
> Basically this code will always give wrong result if run early during page
> load:
> 
> // Send Page.setForcedAppearance with "appearance":"Light"
> // navigate to a page with the following code in its inline script:
> console.log(matchMedia('(prefers-color-scheme: light)').matches);

This has been addressed in the patch for Bug 254457.
The color scheme override will persist on page refresh.