Bug 224474 - Reduce functionWithHellaArguments3()'s number of arguments from 5000 to 500.
Summary: Reduce functionWithHellaArguments3()'s number of arguments from 5000 to 500.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 224495
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-13 00:47 PDT by Mark Lam
Modified: 2021-04-13 11:26 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (170.12 KB, patch)
2021-04-13 00:54 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-13 00:47:02 PDT 
Using 5000 arguments seems excessive, and may blow out the stack on more resource constrained devices.  500 should be high enough.

rdar://73614896
Comment 1 Mark Lam 2021-04-13 00:54:38 PDT 
Created attachment 425844 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-04-13 00:56:08 PDT 
Comment on attachment 425844 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2021-04-13 01:05:08 PDT 
Thanks for the review.  Landed in r275867: <http://trac.webkit.org/r275867>.
Comment 4 Saam Barati 2021-04-13 10:05:57 PDT 
Comment on attachment 425844 [details]
proposed patch.

Why are we changing this? Did you go back in time to verify the test is still doing what it originally was testing?
Comment 5 Saam Barati 2021-04-13 10:07:09 PDT 
(In reply to Saam Barati from comment #4)
> Comment on attachment 425844 [details]
> proposed patch.
> 
> Why are we changing this? Did you go back in time to verify the test is
> still doing what it originally was testing?

I remember now something about some llvm bug. You could just JIT "functionWithHellaArguments" so that we're still testing what we intended to in B3/Air.
Comment 6 WebKit Commit Bot 2021-04-13 11:26:53 PDT 
Re-opened since this is blocked by bug 224495