Bug 224473 - [JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
Summary: [JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-12 22:40 PDT by Yusuke Suzuki
Modified: 2021-04-13 03:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.92 KB, patch)
2021-04-12 22:47 PDT, Yusuke Suzuki 		mark.lam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-04-12 22:40:17 PDT 
[JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
Comment 1 Yusuke Suzuki 2021-04-12 22:47:30 PDT 
Created attachment 425837 [details]
Patch
Comment 2 Mark Lam 2021-04-12 23:40:05 PDT 
Comment on attachment 425837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425837&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        And it array is effectively accessed only when compiling DFG code. So we should remove copy of that in CodeBlock, and

/it array/the array/
Comment 3 Yusuke Suzuki 2021-04-13 00:02:16 PDT 
Comment on attachment 425837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425837&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:13
>> +        And it array is effectively accessed only when compiling DFG code. So we should remove copy of that in CodeBlock, and
> 
> /it array/the array/

Fixed.
Comment 4 Yusuke Suzuki 2021-04-13 00:08:04 PDT 
inspector/canvas/shaderProgram-add-remove-webgpu.html is flaky (it was failing with the same kind of error).
Comment 5 Yusuke Suzuki 2021-04-13 00:35:47 PDT 
Committed r275866 (236431@main): <https://commits.webkit.org/236431@main>
Comment 6 Radar WebKit Bug Importer 2021-04-13 00:36:14 PDT 
<rdar://problem/76578949>
Comment 7 Yusuke Suzuki 2021-04-13 01:34:56 PDT 
Committed r275870 (236435@main): <https://commits.webkit.org/236435@main>