Bug 224464 – Remove SharedBuffer's equality operators with Ref<SharedBuffer>

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Remove SharedBuffer's equality operators with Ref<SharedBuffer>

[Alex Christensen]

Created attachment 425814 [details]
Patch

[Chris Dumez]

Comment on attachment 425814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425814&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:588
> +        if (anyOf(sessionKeys, [&](const Ref<SharedBuffer>& sessionKey) {

The new code looks worse?

What's wrong with comparing a Ref<> with a C++ reference? I can compare a RefPtr<> with a raw pointer already so why is this different?

[Alex Christensen]

That's exactly what I'm trying to do in bug 224412 but can't until I do this.  This compares a Ref<SharedBuffer> and a SharedBuffer& by calling SharedBuffer::operator== which compares the bytes contained in the SharedBuffer's segments.  What I want is a pointer comparison, which is why I have to make these two call sites look worse before introducing a generic Ref equality operator without breaking them.

[Chris Dumez]

Comment on attachment 425814 [details]
Patch

Oh, I missed that. Yes, I agree then.

[EWS]

Committed r275900 (236465@main): <https://commits.webkit.org/236465@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425814 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76605767>