Bug 224451 - Remove support for NPAPI plugins in WKWebView
Summary: Remove support for NPAPI plugins in WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 224441
  Show dependency tree / graph
 
Reported: 2021-04-12 13:57 PDT by Alex Christensen
Modified: 2021-04-13 14:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2021-04-12 14:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (5.66 KB, patch)
2021-04-12 14:53 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-04-12 13:57:17 PDT 
Remove support for NPAPI plugins in WKWebView
Comment 1 Alex Christensen 2021-04-12 14:12:45 PDT 
Created attachment 425788 [details]
Patch
Comment 2 Chris Dumez 2021-04-12 14:39:07 PDT 
Comment on attachment 425788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425788&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:-1520
> -    _preferences->setPluginsEnabled(plugInsEnabled);

I think we should add a RELEASE_LOG_FAULT() when this is called with plugInsEnabled. This should make issues way more obvious in the sysdiagnoses.
Comment 3 Alex Christensen 2021-04-12 14:53:29 PDT 
Created attachment 425795 [details]
Patch
Comment 4 EWS 2021-04-13 14:18:35 PDT 
Committed r275910 (236474@main): <https://commits.webkit.org/236474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425795 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-13 14:19:14 PDT 
<rdar://problem/76610110>