[JSC] Do not copy StringSwitchJumpTable

[Yusuke Suzuki]

[JSC] Do not copy StringSwitchJumpTable

[Yusuke Suzuki]

Created attachment 425699 [details]
Patch

[Yusuke Suzuki]

My plan is doing the similar thing for SimpleJumpTable, but that was a bit more complicated.

[Keith Miller]

Comment on attachment 425699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425699&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        Previously, we are copying UnlinkedStringJumpTable to CodeBlock's StringJumpTable because we are embedding CodeLocation pointer

Nit: Since previously is past tense the verb should be were rather than are. Also: "because we are embedding" => "because we embed"

> Source/JavaScriptCore/ChangeLog:9
> +        inside CodeBlock's StringJumpTable. This is copying mostly identical hashtable to each CodeBlock even in DFG and FTL. And this

Nit: "copying mostly" => "copying a mostly". You can also drop the "and in the third sentence.

> Source/JavaScriptCore/ChangeLog:10
> +        even prevents us from inlining op_switch_string in DFG and FTL.

Maybe explain why it prevents inlining.

> Source/JavaScriptCore/ChangeLog:15
> +        from copying unnecessary hashtable, and even this paves the way to inlining switch_string in DFG and FTL.

Nit: hashtables*

[Yusuke Suzuki]

Committed r275840 (236408@main): <https://commits.webkit.org/236408@main>

[Radar WebKit Bug Importer]

<rdar://problem/76559929>