Bug 224404 – RenderFlexibleBox::m_hasDefiniteHeight should not need to be mutable

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

fix constness instead.

[zalan]

Created attachment 425684 [details]
Patch

[EWS]

Committed r275796 (236367@main): <https://commits.webkit.org/236367@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425684 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76491463>

[Sergio Villar Senin]

I know I'm a bit late but I slightly disagree with this change. The reason why we kept it as mutable is because there are several methods like:

childMainSizeIsDefinite()
childCrossSizeIsDefinite()
childHasIntrinsicMainAxisSize()

that should be really const as we're just checking some values, they are not meant to change the internal state of the object. The m_hasDefiniteHeight is more a cache than part of the internal state of the object as checking definiteness is sometimes pretty expensive.

[zalan]

(In reply to Sergio Villar Senin from comment #4)
> I know I'm a bit late but I slightly disagree with this change. The reason
> why we kept it as mutable is because there are several methods like:
> 
> childMainSizeIsDefinite()
> childCrossSizeIsDefinite()
> childHasIntrinsicMainAxisSize()
> 
> that should be really const as we're just checking some values, they are not
> meant to change the internal state of the object. The m_hasDefiniteHeight is
> more a cache than part of the internal state of the object as checking
> definiteness is sometimes pretty expensive.
Having mutable to solve issues like this is sometimes an indication of a bigger design problem. I prefer solving them instead (and while this change is not addressing that but it may force you in a long run).