Bug 224399 - webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes
Summary: webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 224439 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-04-09 16:30 PDT by Chris Dumez
Modified: 2021-04-12 14:29 PDT (History)
11 users (show)

See Also:

Attachments
Patch (18.60 KB, patch)
2021-04-12 11:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (19.11 KB, patch)
2021-04-12 12:31 PDT, Chris Dumez 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-09 16:30:07 PDT 
webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes (and thus OfflineAudioContexts).
Comment 1 Chris Dumez 2021-04-12 11:36:33 PDT 
*** Bug 224439 has been marked as a duplicate of this bug. ***
Comment 2 Chris Dumez 2021-04-12 11:57:58 PDT 
Created attachment 425771 [details]
Patch
Comment 3 Chris Dumez 2021-04-12 12:31:34 PDT 
Created attachment 425774 [details]
Patch
Comment 4 Geoffrey Garen 2021-04-12 13:59:00 PDT 
Comment on attachment 425774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425774&action=review

r=me

> Source/WebCore/ChangeLog:33
> +        Early return if lazyInitialize() gets called for au audiocontext is closed. Nothing prevents JS from

for au => after an

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:184
> +bool AudioScheduledSourceNode::virtualHasPendingActivity() const

Not for this patch, but this function really needs a better to name to clarify that it is an addition, *not* an override.

Maybe "hasAdditionalPendingActivity" or something like that.
Comment 5 Chris Dumez 2021-04-12 14:28:37 PDT 
Committed r275838 (236406@main): <https://commits.webkit.org/236406@main>
Comment 6 Radar WebKit Bug Importer 2021-04-12 14:29:31 PDT 
<rdar://problem/76558119>