Bug 224379 - WTF SoftLinking macros can cause collisions with their target functions
Summary: WTF SoftLinking macros can cause collisions with their target functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-09 11:12 PDT by Jer Noble
Modified: 2021-04-09 14:44 PDT (History)
12 users (show)

See Also:

Attachments
Patch (20.62 KB, patch)
2021-04-09 11:19 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.99 KB, patch)
2021-04-09 11:28 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-04-09 11:12:25 PDT 
WTF SoftLinking macros can cause collisions with their target functions
Comment 1 Jer Noble 2021-04-09 11:14:18 PDT 
<rdar://76434202>
Comment 2 Jer Noble 2021-04-09 11:19:22 PDT 
Created attachment 425635 [details]
Patch
Comment 3 Jer Noble 2021-04-09 11:28:33 PDT 
Created attachment 425637 [details]
Patch
Comment 4 Eric Carlson 2021-04-09 13:22:08 PDT 
Comment on attachment 425637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425637&action=review

> Source/WebCore/xml/SoftLinkLibxslt.h:27
> +

Nit: extra blank line
Comment 5 Jer Noble 2021-04-09 13:32:01 PDT 
Comment on attachment 425637 [details]
Patch

Clearing flags on attachment: 425637

Committed r275775 (236350@main): <https://commits.webkit.org/236350@main>
Comment 6 Jer Noble 2021-04-09 13:32:04 PDT 
All reviewed patches have been landed.  Closing bug.