Bug 224351 – Safari unit tests sometimes fail an ASSERTion in IOSurface.mm's optionsFor32BitSurface()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Safari unit tests sometimes fail an ASSERTion in IOSurface.mm's optionsFor32BitSurface()

[Tim Horton]

Created attachment 425565 [details]
Patch

[Tim Horton]

<rdar://problem/76405354>

[Wenson Hsieh]

Comment on attachment 425565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425565&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:209
> +    ASSERT(size.width());
> +    ASSERT(size.height());

Nit - perhaps just `ASSERT(!size.isEmpty());` would be cleaner?

[Tim Horton]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 425565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425565&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:209
> > +    ASSERT(size.width());
> > +    ASSERT(size.height());
> 
> Nit - perhaps just `ASSERT(!size.isEmpty());` would be cleaner?

Sure, that ... seems like the obvious thing to do, in hindsight.

[Tim Horton]

Created attachment 425566 [details]
Patch

[EWS]

Committed r275737 (236324@main): <https://commits.webkit.org/236324@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425566 [details].