Bug 224337 – [Metal-ANGLE] Support GPU power preferences, select low-power GPU by default.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kyle Piddington]

[Metal-ANGLE] Support GPU power preferences, select low-power GPU by default.

[Kyle Piddington]

Created attachment 425537 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Jon Lee]

rdar://75823830

[Dean Jackson]

Comment on attachment 425537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425537&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:278
> +    //TODO: External GPU support. Do we prefer high power / low bandwidth for general WebGL applications?
> +    //      Can we support hot-swapping in GPU's?

This is a good question. I would assume that if someone has an external GPU they want to use it. And it is likely that their display is running through it or, even if it's a laptop, they are using it as the primary display. So we should probably use any external GPU before even checking for the low-power/high-power flag. But this doesn't need to be fixed now.

[EWS]

Committed r275685 (236319@main): <https://commits.webkit.org/236319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425537 [details].

[Kimmo Kinnunen]

Comment on attachment 425537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425537&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:432
> +    outExtensions->powerPreference = true;

This is not really correct, I don't think the implementation supports the methods defined in the extension..