Bug 224332 - Remove virtual from RenderBox::availableLogicalWidth
Summary: Remove virtual from RenderBox::availableLogicalWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-08 11:45 PDT by Rob Buis
Modified: 2021-04-08 13:47 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2021-04-08 11:46 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2021-04-08 12:56 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-04-08 11:45:18 PDT
Remove virtual from RenderBox::availableLogicalWidth since
it is not overwritten.
Comment 1 Rob Buis 2021-04-08 11:46:26 PDT
Created attachment 425526 [details]
Patch
Comment 2 Darin Adler 2021-04-08 12:50:32 PDT
Comment on attachment 425526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review

> Source/WebCore/ChangeLog:9
> +        it is not overwritten.

overwritten -> overridden
Comment 3 Rob Buis 2021-04-08 12:53:39 PDT
Comment on attachment 425526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review

>> Source/WebCore/ChangeLog:9
>> +        it is not overwritten.
> 
> overwritten -> overridden

Thanks, was doing too many things at once. I think for mistakes like this it would be nice to be able to edit the commit message and spare the re-upload.
Comment 4 Rob Buis 2021-04-08 12:56:24 PDT
Created attachment 425535 [details]
Patch
Comment 5 EWS 2021-04-08 13:46:29 PDT
Committed r275675 (236311@main): <https://commits.webkit.org/236311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425535 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-08 13:47:13 PDT
<rdar://problem/76419632>