Bug 224329 - Make TestInput take a Test object, not a path
Summary: Make TestInput take a Test object, not a path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks: 220421
  Show dependency tree / graph
 
Reported: 2021-04-08 09:41 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-09 12:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (32.68 KB, patch)
2021-04-08 09:59 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (34.37 KB, patch)
2021-04-08 10:26 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (36.53 KB, patch)
2021-04-09 05:49 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (36.62 KB, patch)
2021-04-09 09:29 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-08 09:41:47 PDT 
Continue to refactor webkitpy.layout_tests to represent tests as objects, rather than as test names (i.e., paths). This is required so that we can attach data, like expectations, to the tests and pass them through the various components, rather than having to do multiple walks of the tree to find them.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-08 09:59:46 PDT 
Created attachment 425512 [details]
Patch
Comment 2 Sam Sneddon [:gsnedders] 2021-04-08 10:26:34 PDT 
Created attachment 425516 [details]
Patch
Comment 3 Jonathan Bedard 2021-04-08 11:38:10 PDT 
Comment on attachment 425516 [details]
Patch

Looks good, let's wait for iOS layout tests, since that's the configuration most likely to be broken by this.
Comment 4 Sam Sneddon [:gsnedders] 2021-04-09 05:49:27 PDT 
Created attachment 425615 [details]
Patch
Comment 5 Sam Sneddon [:gsnedders] 2021-04-09 05:50:33 PDT 
Comment on attachment 425615 [details]
Patch

https://github.com/WebKit/WebKit/compare/main...gsnedders:test_obj_to_runner?expand=1 has the history from the first patch, in case that helps to review.
Comment 6 Sam Sneddon [:gsnedders] 2021-04-09 09:29:39 PDT 
Created attachment 425626 [details]
Patch
Comment 7 EWS 2021-04-09 12:50:06 PDT 
Committed r275773 (236348@main): <https://commits.webkit.org/236348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425626 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-09 12:51:16 PDT 
<rdar://problem/76465565>