WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 224329
Make TestInput take a Test object, not a path
https://bugs.webkit.org/show_bug.cgi?id=224329
Summary
Make TestInput take a Test object, not a path
Sam Sneddon [:gsnedders]
Reported
2021-04-08 09:41:47 PDT
Continue to refactor webkitpy.layout_tests to represent tests as objects, rather than as test names (i.e., paths). This is required so that we can attach data, like expectations, to the tests and pass them through the various components, rather than having to do multiple walks of the tree to find them.
Attachments
Patch
(32.68 KB, patch)
2021-04-08 09:59 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
Formatted Diff
Diff
Patch
(34.37 KB, patch)
2021-04-08 10:26 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
Formatted Diff
Diff
Patch
(36.53 KB, patch)
2021-04-09 05:49 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
Formatted Diff
Diff
Patch
(36.62 KB, patch)
2021-04-09 09:29 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2021-04-08 09:59:46 PDT
Created
attachment 425512
[details]
Patch
Sam Sneddon [:gsnedders]
Comment 2
2021-04-08 10:26:34 PDT
Created
attachment 425516
[details]
Patch
Jonathan Bedard
Comment 3
2021-04-08 11:38:10 PDT
Comment on
attachment 425516
[details]
Patch Looks good, let's wait for iOS layout tests, since that's the configuration most likely to be broken by this.
Sam Sneddon [:gsnedders]
Comment 4
2021-04-09 05:49:27 PDT
Created
attachment 425615
[details]
Patch
Sam Sneddon [:gsnedders]
Comment 5
2021-04-09 05:50:33 PDT
Comment on
attachment 425615
[details]
Patch
https://github.com/WebKit/WebKit/compare/main...gsnedders:test_obj_to_runner?expand=1
has the history from the first patch, in case that helps to review.
Sam Sneddon [:gsnedders]
Comment 6
2021-04-09 09:29:39 PDT
Created
attachment 425626
[details]
Patch
EWS
Comment 7
2021-04-09 12:50:06 PDT
Committed
r275773
(
236348@main
): <
https://commits.webkit.org/236348@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 425626
[details]
.
Radar WebKit Bug Importer
Comment 8
2021-04-09 12:51:16 PDT
<
rdar://problem/76465565
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug