Bug 224312 - Bugzilla needs to linkify identifiers
Summary: Bugzilla needs to linkify identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 224325 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-04-07 16:43 PDT by Jonathan Bedard
Modified: 2021-04-27 09:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.81 KB, patch)
2021-04-07 16:53 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (9.31 KB, patch)
2021-04-23 16:31 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2021-04-26 11:05 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-04-07 16:43:45 PDT
Bugzilla linkifies revisions, but not identifiers.
Comment 1 Jonathan Bedard 2021-04-07 16:47:55 PDT
<rdar://problem/75845629>
Comment 2 Jonathan Bedard 2021-04-07 16:53:46 PDT
Created attachment 425455 [details]
Patch
Comment 3 Jonathan Bedard 2021-04-07 16:56:09 PDT
(In reply to Jonathan Bedard from comment #2)
> Created attachment 425455 [details]
> Patch

I'm intend to include this change in the same extension used to linkify revisions. First step is to rename the extension.
Comment 4 Alexey Proskuryakov 2021-04-08 07:05:32 PDT
*** Bug 224325 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Bedard 2021-04-23 16:31:45 PDT
Created attachment 426964 [details]
Patch
Comment 6 dewei_zhu 2021-04-23 16:43:48 PDT
Comment on attachment 426964 [details]
Patch

r=me
Comment 7 EWS 2021-04-23 17:18:38 PDT
Committed r276536 (236983@main): <https://commits.webkit.org/236983@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426964 [details].
Comment 8 Jonathan Bedard 2021-04-26 11:05:09 PDT
Reopening to attach new patch.
Comment 9 Jonathan Bedard 2021-04-26 11:05:10 PDT
Created attachment 427062 [details]
Patch
Comment 10 Aakash Jain 2021-04-27 08:25:34 PDT
Comment on attachment 427062 [details]
Patch

rs=me

Is the linking to commits.webkit.org long-term solution, or after we move to github, we should link directly to github instead of using one translation layer in between?
Comment 11 Jonathan Bedard 2021-04-27 08:30:52 PDT
(In reply to Aakash Jain from comment #10)
> Comment on attachment 427062 [details]
> Patch
> 
> rs=me
> 
> Is the linking to commits.webkit.org long-term solution, or after we move to
> github, we should link directly to github instead of using one translation
> layer in between?

That's our long-term solution, because we don't expect that GitHub will ever support identifiers natively.
Comment 12 EWS 2021-04-27 08:34:53 PDT
Committed r276640 (237068@main): <https://commits.webkit.org/237068@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427062 [details].
Comment 13 Jonathan Bedard 2021-04-27 09:50:06 PDT
Deployed this to bugs.webkit.org